Windows smoke tests for WildFly #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vovencij
approved these changes
Jan 26, 2021
But Otel does build Liberty images for linux. Or is logging required only for windows images? |
iNikem
approved these changes
Jan 26, 2021
As OTel uses OpenLiberty for Linux images, added Windows images of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates Windows Docker images for the same set of WildFly version and JDK combinations as upstream OTel publishes for Linux. Adds smoke tests configurations for those images.
Original plan was to add WebSphere Liberty as well, but downloading its distributions requires logging in with an IBM account, so it would not currently be possible to build those images locally in Github Actions. Will have to revisit that when we have a way to use prebuilt proprietary images in the CI pipeline.