Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin servlet api version for smoke test app #1496

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Pin servlet api version for smoke test app #1496

merged 1 commit into from
Oct 20, 2023

Conversation

laurit
Copy link
Collaborator

@laurit laurit commented Oct 20, 2023

No description provided.

@laurit laurit requested review from a team as code owners October 20, 2023 11:57
mateuszrzeszutek
mateuszrzeszutek approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to pinning the version

@laurit laurit merged commit 62e4fa0 into signalfx:main Oct 20, 2023
31 checks passed
@laurit laurit deleted the pin-servlet-api branch October 20, 2023 12:22
@breedx-splk
Copy link
Contributor

I think I agree with this, but realistically, how often does the servlet api actually change anyway? 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurit @breedx-splk @mateuszrzeszutek