Export JVM metrics from the javaagent using micrometer #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README changes will be added in a separate PR
jkwatson
reviewed
Mar 12, 2021
custom/src/main/java/com/splunk/opentelemetry/micrometer/OtelNamingConvention.java
Show resolved
Hide resolved
jkwatson
approved these changes
Mar 12, 2021
breedx-splk
requested changes
Mar 12, 2021
custom/src/main/java/com/splunk/opentelemetry/micrometer/MicrometerInstaller.java
Outdated
Show resolved
Hide resolved
custom/src/main/java/com/splunk/opentelemetry/micrometer/MicrometerInstaller.java
Outdated
Show resolved
Hide resolved
bootstrap/src/main/java/com/splunk/opentelemetry/javaagent/bootstrap/GlobalMetricsTags.java
Show resolved
Hide resolved
custom/src/main/java/com/splunk/opentelemetry/micrometer/OtelNamingConvention.java
Outdated
Show resolved
Hide resolved
custom/src/main/java/com/splunk/opentelemetry/micrometer/SplunkMetricsConfig.java
Outdated
Show resolved
Hide resolved
custom/src/main/java/com/splunk/opentelemetry/micrometer/SplunkMetricsConfig.java
Outdated
Show resolved
Hide resolved
custom/src/main/java/com/splunk/opentelemetry/micrometer/SplunkMetricsConfig.java
Outdated
Show resolved
Hide resolved
...ation/jvm-metrics/src/main/java/com/splunk/opentelemetry/jvmmetrics/JvmMetricsInstaller.java
Show resolved
Hide resolved
iNikem
reviewed
Mar 15, 2021
custom/src/main/java/com/splunk/opentelemetry/micrometer/SplunkMetricsConfig.java
Outdated
Show resolved
Hide resolved
...umentation/jvm-metrics/src/test/java/com/splunk/opentelemetry/jvmmetrics/JvmMetricsTest.java
Show resolved
Hide resolved
ghost
reviewed
Mar 15, 2021
custom/src/main/java/com/splunk/opentelemetry/micrometer/OtelNamingConvention.java
Outdated
Show resolved
Hide resolved
ghost
reviewed
Mar 15, 2021
custom/src/main/java/com/splunk/opentelemetry/micrometer/MicrometerInstaller.java
Show resolved
Hide resolved
|
Seems like the tests have passed (at least the linux ones...) -- @iNikem @kubawach @breedx-splk @jkwatson I've addressed all your comments, please re-review this PR 🙏 |
jkwatson
reviewed
Mar 17, 2021
custom/src/test/java/com/splunk/opentelemetry/micrometer/OtelNamingConventionTest.java
Outdated
Show resolved
Hide resolved
jkwatson
reviewed
Mar 17, 2021
custom/src/test/java/com/splunk/opentelemetry/micrometer/GlobalTagsBuilderTest.java
Show resolved
Hide resolved
jkwatson
reviewed
Mar 17, 2021
| 12345L)); | ||
|
|
||
| // when | ||
| var tags = new GlobalTagsBuilder(resource).build(); |
There was a problem hiding this comment.
java 11 in tests.. is there gradle magic that makes sure our code doesn't start using java 11 APIs that would break users on java 8?
There was a problem hiding this comment.
Yes, there is:
compileJava {
options.release.set(8)
}AFAIK this adds --release 8 when compiling src/main classes.
breedx-splk
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README changes will be added in a separate PR