Add support for access token and cleanup other configs #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MrAlias can you review it, please? |
owais
approved these changes
May 12, 2021
MrAlias
reviewed
May 14, 2021
Co-authored-by: Tyler Yahn <[email protected]>
MrAlias
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The user may want to send traces directly to Splunk back-end.
What
Testing
Added integration tests using
httptest.Server.Tested manually with real Jaeger and Splunk-backend with @owais (thank you!). Results below:
Remarks
@MrAlias
Bug in OTel Go SDK discovered. Basically it is defaulting to the gRPC endpoint http://localhost:14250 instead of the HTTP thrift endpoint http://localhost:14268/api/traces .
Here is a PR in OTel Go repository: open-telemetry/opentelemetry-go#1898
Next PR