-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to semconv v1.17.0 #1749
Conversation
Codecov ReportBase: 81.93% // Head: 81.23% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1749 +/- ##
==========================================
- Coverage 81.93% 81.23% -0.70%
==========================================
Files 63 63
Lines 2651 2670 +19
==========================================
- Hits 2172 2169 -3
- Misses 430 449 +19
- Partials 49 52 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ce796ce
to
91c31dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit comments only
Co-authored-by: Robert Pająk <[email protected]>
Related OTel specification change PRs for net/http/messaging semantic conventions:
Added
NetSockFamily
type and related variables to be use in theConnectionConfig
fromgithub.com/signalfx/splunk-otel-go/instrumentation/database/sql/splunksql
.Changed
NetSockFamily
field to theConnectionConfig
ingithub.com/signalfx/splunk-otel-go/instrumentation/database/sql/splunksql
. This is used to define the protocol address family used for communication to the database.go.opentelemetry.io/otel/semconv
tov1.17.0
in the following packages.github.com/signalfx/splunk-otel-go/distro
github.com/signalfx/splunk-otel-go/instrumentation/database/sql/splunksql
github.com/signalfx/splunk-otel-go/instrumentation/github.com/confluentinc/confluent-kafka-go/kafka/splunkkafka
github.com/signalfx/splunk-otel-go/instrumentation/github.com/go-chi/chi/splunkchi
github.com/signalfx/splunk-otel-go/instrumentation/github.com/go-sql-driver/mysql/splunkmysql
github.com/signalfx/splunk-otel-go/instrumentation/github.com/gomodule/redigo/splunkredigo
github.com/signalfx/splunk-otel-go/instrumentation/github.com/jackc/pgx/splunkpgx
github.com/signalfx/splunk-otel-go/instrumentation/github.com/jackc/pgx/splunkpgx
github.com/signalfx/splunk-otel-go/instrumentation/github.com/syndtr/goleveldb/leveldb/splunkleveldb
github.com/signalfx/splunk-otel-go/instrumentation/github.com/tidwall/buntdb/splunkbuntdb
github.com/signalfx/splunk-otel-go/instrumentation/gopkg.in/olivere/elastic/splunkelastic
github.com/signalfx/splunk-otel-go/instrumentation/k8s.io/client-go/splunkclient-go
Deprecated
NetTransportIP
andNetTransportUnix
variables fromgithub.com/signalfx/splunk-otel-go/instrumentation/database/sql/splunksql
are deprecated as they are no longer supported in upstream semantic conventions. Use an appropriateNetSockFamily*
variable instead.