Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to semconv v1.17.0 #1749

Merged
merged 5 commits into from
Feb 1, 2023
Merged

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jan 31, 2023

Related OTel specification change PRs for net/http/messaging semantic conventions:

Added

  • The NetSockFamily type and related variables to be use in the ConnectionConfig from github.com/signalfx/splunk-otel-go/instrumentation/database/sql/splunksql.

Changed

  • Add the NetSockFamily field to the ConnectionConfig in github.com/signalfx/splunk-otel-go/instrumentation/database/sql/splunksql. This is used to define the protocol address family used for communication to the database.
  • Update go.opentelemetry.io/otel/semconv to v1.17.0 in the following packages.
    • github.com/signalfx/splunk-otel-go/distro
    • github.com/signalfx/splunk-otel-go/instrumentation/database/sql/splunksql
    • github.com/signalfx/splunk-otel-go/instrumentation/github.com/confluentinc/confluent-kafka-go/kafka/splunkkafka
    • github.com/signalfx/splunk-otel-go/instrumentation/github.com/go-chi/chi/splunkchi
    • github.com/signalfx/splunk-otel-go/instrumentation/github.com/go-sql-driver/mysql/splunkmysql
    • github.com/signalfx/splunk-otel-go/instrumentation/github.com/gomodule/redigo/splunkredigo
    • github.com/signalfx/splunk-otel-go/instrumentation/github.com/jackc/pgx/splunkpgx
    • github.com/signalfx/splunk-otel-go/instrumentation/github.com/jackc/pgx/splunkpgx
    • github.com/signalfx/splunk-otel-go/instrumentation/github.com/syndtr/goleveldb/leveldb/splunkleveldb
    • github.com/signalfx/splunk-otel-go/instrumentation/github.com/tidwall/buntdb/splunkbuntdb
    • github.com/signalfx/splunk-otel-go/instrumentation/gopkg.in/olivere/elastic/splunkelastic
    • github.com/signalfx/splunk-otel-go/instrumentation/k8s.io/client-go/splunkclient-go

Deprecated

  • The NetTransportIP and NetTransportUnix variables from github.com/signalfx/splunk-otel-go/instrumentation/database/sql/splunksql are deprecated as they are no longer supported in upstream semantic conventions. Use an appropriate NetSockFamily* variable instead.

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023

Codecov Report

Base: 81.93% // Head: 81.23% // Decreases project coverage by -0.70% ⚠️

Coverage data is based on head (01b9f28) compared to base (824d1c1).
Patch coverage: 65.21% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1749      +/-   ##
==========================================
- Coverage   81.93%   81.23%   -0.70%     
==========================================
  Files          63       63              
  Lines        2651     2670      +19     
==========================================
- Hits         2172     2169       -3     
- Misses        430      449      +19     
- Partials       49       52       +3     
Flag Coverage Δ
Linux 80.86% <65.21%> (-0.70%) ⬇️
Windows 77.40% <60.00%> (-0.75%) ⬇️
macOS 76.96% <62.31%> (-0.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
distro/otel.go 65.57% <ø> (ø)
instrumentation/database/sql/splunksql/conn.go 91.47% <ø> (ø)
instrumentation/database/sql/splunksql/dbsystem.go 57.14% <ø> (ø)
instrumentation/database/sql/splunksql/stmt.go 88.67% <ø> (ø)
...inc/confluent-kafka-go/kafka/splunkkafka/config.go 100.00% <ø> (ø)
...hub.com/gomodule/redigo/splunkredigo/redis/conn.go 100.00% <ø> (ø)
...m/syndtr/goleveldb/leveldb/splunkleveldb/config.go 80.00% <ø> (ø)
...b.com/syndtr/goleveldb/leveldb/splunkleveldb/db.go 93.75% <ø> (ø)
...syndtr/goleveldb/leveldb/splunkleveldb/iterator.go 100.00% <ø> (ø)
...syndtr/goleveldb/leveldb/splunkleveldb/snapshot.go 100.00% <ø> (ø)
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MrAlias MrAlias force-pushed the update-semconv-v1.17 branch from ce796ce to 91c31dc Compare January 31, 2023 21:42
@MrAlias MrAlias marked this pull request as ready for review January 31, 2023 21:50
@MrAlias MrAlias requested review from a team as code owners January 31, 2023 21:50
Copy link
Contributor

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit comments only

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@pellared pellared merged commit 12ee32b into signalfx:main Feb 1, 2023
@MrAlias MrAlias deleted the update-semconv-v1.17 branch February 1, 2023 15:31
@MrAlias MrAlias mentioned this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants