Deprecate SPLUNK_TRACE_URL env var and don't use it in default configs #5672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
deprecate-trace-url-env-var
branch
2 times, most recently
from
63596b9 to
9608808
Compare
dmitryax
force-pushed
the
deprecate-trace-url-env-var
branch
7 times, most recently
from
9d2dc59 to
c53af48
Compare
Deprecate `SPLUNK_TRACE_URL` environment variable and replace with `${SPLUNK_INGEST_URL}/v2/trace`in the default configs. `SPLUNK_TRACE_URL` is still automatically set in the binary computed from on `SPLUNK_REALM` or `SPLUNK_INGEST_URL` environment variables to not break existing configurations. However, it is recommended to
update the configurations to use `${SPLUNK_INGEST_URL}/v2/trace` instead.
Also, packaging and mass deployment solutions were update to not provide the option to set the Trace URL since it's not being used anymore in the default configs.
dmitryax
force-pushed
the
deprecate-trace-url-env-var
branch
from
c53af48 to
659ac72
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
SPLUNK_TRACE_URLenvironment variable and replace with${SPLUNK_INGEST_URL}/v2/tracein the default configs.SPLUNK_TRACE_URLis still automatically set in the binary computed from onSPLUNK_REALMorSPLUNK_INGEST_URLenvironment variables to not break existing configurations. However, it is recommended toupdate the configurations to use
${SPLUNK_INGEST_URL}/v2/traceinstead.Also, packaging and mass deployment solutions were update to not provide the option to set the Trace URL since it's not being used anymore in the default configs.