Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Stabilize lychee links validation #5668

Merged
merged 1 commit into from
Dec 4, 2024
Merged

[CI] Stabilize lychee links validation #5668

merged 1 commit into from
Dec 4, 2024

Conversation

dmitryax
Copy link
Contributor

@dmitryax dmitryax commented Dec 4, 2024 •
edited
Loading

  • Exclude checking PRs and issues. There are too many of them in CHANGELOG.md, so we always run into the rate limits.
  • Use the latest lychee build that has fixed retries Fix retries lycheeverse/lychee#1573
  • Increase the number of retries and retry timeout to workaround secondary Github rate limiting
  • Do not consider 429 successful

There is one failing link left which is fixed in #5667

@dmitryax dmitryax requested review from a team as code owners December 4, 2024 03:10
@dmitryax dmitryax force-pushed the cache-lychee-responses branch 3 times, most recently from 947cd72 to acadee0 Compare December 4, 2024 19:28
@dmitryax dmitryax changed the title [CI] Cache lychee results for one day [CI] Do not validate pull request links Dec 4, 2024
@dmitryax dmitryax force-pushed the cache-lychee-responses branch 5 times, most recently from 001a804 to 6cb0578 Compare December 4, 2024 22:11
@dmitryax dmitryax changed the title [CI] Do not validate pull request links [CI] Stabilize lychee links validation Dec 4, 2024
@dmitryax
[CI] Do not validate pull request links
7cca409 
There are too many of them so we always run into rate limiting
@dmitryax dmitryax force-pushed the cache-lychee-responses branch from 19ece1e to 7cca409 Compare December 4, 2024 22:38
@dmitryax dmitryax merged commit 3f739af into main Dec 4, 2024
2 checks passed
@dmitryax dmitryax deleted the cache-lychee-responses branch December 4, 2024 22:39
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pjanotti pjanotti pjanotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmitryax @pjanotti