[discovery] Apply entity events schema the discovery receiver logs #4638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
emit-entity-events
branch
6 times, most recently
from
2c78796 to
0d70849
Compare
|
TestDiscoveryReceiverWithHostObserverAndSimplePrometheusReceiverProvideStatusLogs -> failing. |
samiura
force-pushed
the
emit-entity-events
branch
from
0d70849 to
eafebf2
Compare
Rebasing.... |
dmitryax
force-pushed
the
emit-entity-events
branch
5 times, most recently
from
d3398fe to
2c70ca2
Compare
This change updates the schema of the logs emitted by the discovery receiver to represent entity events. No information is dropped, but it was reshuffled to adopt for the new schema: - Entity ID is made of one key/value pair moved from `discovery.endpoint.id` resource attribute - All other resource attributes are moved to the entity state event attributes - Log body was moved to the `discovery.event.message` entity state attribute The Discovery config provider is updated to use the entity events. The keys used in the entity ID and entity attributes are not finalized and are expected to be changed in the following PRs.
dmitryax
force-pushed
the
emit-entity-events
branch
from
622b83e to
b6a351d
Compare
samiura
approved these changes
Apr 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the schema of the logs emitted by the discovery receiver to represent entity events. No information is dropped, but it was reshuffled to adopt for the new schema:
discovery.endpoint.idresource attributediscovery.event.messageentity state attributeThe Discovery config provider is updated to use the entity events.
The keys used in the entity ID and entity attributes are not finalized and are expected to be changed in the following PRs.