[discovery] Emit only one log record per matched endpoint #4586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is another step towards migrating from the discovery events to entity events. Entity batch has to have only one entity with a unique identifier. There is no reason to send a log record for every match. The matching rules should not conflict with each other. We can document and assume that. The receiving part (discovery config provider) don't need all the matching states. It only cares abut the latest state. And the successful state always wins. With this change, in case if we had a conflicting matching rules in both failed, partial and success sections, There is no reason to send log record per every would be unclear. However, given that we don't have any conflicting matching rules in the default discovery receiver configuration, it's safe to proceed. As the next step, we will need to restructure the discovery rules schema to avoid any possible conflicts across different statuses.
dmitryax
force-pushed
the
emit-only-one-discovery-log-per-endpoint
branch
from
b46932a to
913c5d9
Compare
samiura
reviewed
Apr 2, 2024
| if rStatusAttr, ok := lr.Attributes().Get(discovery.StatusAttr); ok { | ||
| rStatus := discovery.StatusType(rStatusAttr.Str()) | ||
| if valid, e := discovery.IsValidStatus(rStatus); !valid { | ||
| d.logger.Debug("invalid status from log record", zap.Error(e), zap.Any("lr", lr.Body().AsRaw())) |
There was a problem hiding this comment.
This is much more readable 👍🏽
samiura
approved these changes
Apr 2, 2024
atoulme
approved these changes
Apr 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another step towards migrating from the discovery events to entity events. Entity batch has to have only one entity with a unique identifier.
There is no reason to send a log record for every match. The matching rules should not conflict with each other. We can document and assume that.
The receiving part (discovery config provider) don't need all the matching states. It only maintains the latest state. And the successful state always wins. With this change, in case if we had conflicting matching rules across failed, partial and success sections, the result would be non-deterministic. However, given that we don't have any conflicting matching rules in the default discovery receiver configuration, it's safe to proceed.
As the next step, we will need to restructure the discovery rules schema to avoid any possible conflicts across different statuses.