Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows multiarch #4296

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Windows multiarch #4296

merged 3 commits into from
Feb 15, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Feb 15, 2024

Description:
Create a multi-arch Windows docker image for the collector.

hughesjj
hughesjj requested changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@hughesjj hughesjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a single bug, and I provided an alternative naming style if you think it's better. If you don't think it's better, just ignore those comments, not worth trying to get broader consensus.

@atoulme atoulme marked this pull request as ready for review February 15, 2024 20:53
@atoulme atoulme requested review from a team as code owners February 15, 2024 20:53
@atoulme atoulme requested a review from hughesjj February 15, 2024 20:53
@atoulme atoulme merged commit 277f52b into main Feb 15, 2024
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the windows_multiarch branch February 15, 2024 21:08
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hughesjj hughesjj hughesjj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atoulme @hughesjj