Update OpenTelemetry Dependencies to latest #4275

srv-gh-o11y-gdi · 2024-02-08T08:16:02Z

Update OpenTelemetry Dependencies to latest

hughesjj · 2024-02-21T17:49:32Z

remaining errors:

2024/02/21 00:27:58 🐳 Starting container: 139a3de24a3e
2024/02/21 00:27:58 🚧 Waiting for container id 139a3de24a3e image: 2a79214e-dfda-4c49-a7d2-3fb6ece6da36:66125ad3-f1be-4528-8caf-031af89f084a
testcase.go:224:
Error Trace: /home/runner/work/splunk-otel-collector/splunk-otel-collector/tests/testutils/testcase.go:224
/home/runner/work/splunk-otel-collector/splunk-otel-collector/tests/testutils/testcase.go:171
/home/runner/work/splunk-otel-collector/splunk-otel-collector/tests/testutils/testcase.go:186
/home/runner/work/splunk-otel-collector/splunk-otel-collector/tests/testutils/testcase.go:158
/home/runner/work/splunk-otel-collector/splunk-otel-collector/tests/testutils/testcase.go:288
/home/runner/work/splunk-otel-collector/splunk-otel-collector/tests/receivers/oracledb/bundled_test.go:33
Error: Received unexpected error:
context deadline exceeded: failed to start container
Test: TestOracledbDockerObserver

        value: 630

contains unexpected metrics otelcol_http_client_duration, otelcol_http_client_request_size, otelcol_http_client_response_size
testcase.go:291:
Error Trace: /home/runner/work/splunk-otel-collector/splunk-otel-collector/tests/testutils/testcase.go:291
/home/runner/work/splunk-otel-collector/splunk-otel-collector/tests/receivers/lightprometheus/internal_prometheus_test.go:33
Error: Received unexpected error:

not sure what's up with "undefined"

    	            	            value: 30.021050929
    	            	 contains unexpected metrics otelcol_http_client_duration, otelcol_http_client_request_size, otelcol_http_client_response_size
    	Test:       	TestInternalPrometheusMetrics

2024/02/21 00:25:46 🐳 Stopping container: f840e02e6bf1
2024/02/21 00:25:46 ✋ Container stopped: f840e02e6bf1
2024/02/21 00:25:46 🐳 Terminating container: f840e02e6bf1
2024/02/21 00:25:46 🚫 Container terminated: f840e02e6bf1
Logs:
{{info 2024-02-21 00:25:13.014312629 +0000 UTC m=+0.005564181 Starting GRPC server undefined } [{endpoint 15 0 localhost:43729 }]}
{{info 2024-02-21 00:25:16.189021984 +0000 UTC m=+3.180273536 2024/02/21 00:25:16 settings.go:479: Set config to [/etc/config.yaml]

. Missing Metrics: [name: gauge.kafka.consumer.fetch-size-avg
type: DoubleGauge
]
testcase.go:291:
Error Trace: /home/runner/work/splunk-otel-collector/splunk-otel-collector/tests/testutils/testcase.go:291
/home/runner/work/splunk-otel-collector/splunk-otel-collector/tests/receivers/smartagent/collectd-kafka/collectd_kafka_test.go:71
Error: Received unexpected error:
instrumentation_scope:

type: IntGauge

. Missing Metrics: [name: gauge.nodes.system.cpu_utilization_rate
type: DoubleGauge
name: gauge.nodes.system.cpu_utilization_rate
type: DoubleGauge
name: gauge.nodes.system.cpu_utilization_rate
type: DoubleGauge
name: gauge.nodes.system.cpu_utilization_rate
type: DoubleGauge
]
testcase.go:291:
Error Trace: /home/runner/work/splunk-otel-collector/splunk-otel-collector/tests/testutils/testcase.go:291
/home/runner/work/splunk-otel-collector/splunk-otel-collector/tests/receivers/smartagent/collectd-couchbase/collectd_couchbase_test.go:33
Error: Received unexpected error:

hughesjj · 2024-02-22T03:26:23Z

@ oracledb issue, upgraded testcontainers and found what's likely the underlying issue. I'm guessing the panic prevented me from seeing it in the debugger? still odd we were able to run it from command line without issue...

panic: invalid character(s) in type "oracledb//receiver_creator/docker_observer{endpoint=\"172.17.0.3:1521\"}/cf434b75eff126e1cb9f5f57d3dd52f756e4060629ed8374f459da025cdbed99:1521"

hughesjj · 2024-02-27T22:34:41Z

@ oracledb issue, upgraded testcontainers and found what's likely the underlying issue. I'm guessing the panic prevented me from seeing it in the debugger? still odd we were able to run it from command line without issue...
panic: invalid character(s) in type "oracledb//receiver_creator/docker_observer{endpoint=\"172.17.0.3:1521\"}/cf434b75eff126e1cb9f5f57d3dd52f756e4060629ed8374f459da025cdbed99:1521"

Opened an issue upstream to resolve

open-telemetry/opentelemetry-collector-contrib#31457

… expandConverter

…eout and build in github

…ceiver.type from env vars

…tinel values instead of empty

…while anyway

…networks

…e file from the troublesome linter (see golangci/golangci-lint#741)

atoulme · 2024-03-01T00:06:46Z

pkg/extension/smartagentextension/go.mod

-	go.opentelemetry.io/collector/extension v0.93.0
+	go.opentelemetry.io/collector/component v0.94.1
+	go.opentelemetry.io/collector/confmap v0.94.1
+	go.opentelemetry.io/collector/extension v0.94.1


0.94.1 used here

Isn't it correct that we want v0.94.1 of core and v0.94.0 of contrib? Or am I missing something?

atoulme · 2024-03-01T00:07:47Z

pkg/receiver/smartagentreceiver/go.mod

-	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/zipkin v0.93.0
+	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/experimentalmetricmetadata v0.94.0
+	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/pdatatest v0.94.0
+	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/zipkin v0.94.0


0.94.0 as well

atoulme · 2024-03-01T00:09:28Z

tests/receivers/smartagent/jmx/testdata/script.groovy

@@ -50,5 +50,4 @@ log.info(ss.Ownership.toString())
 output.sendDatapoint(util.makeGauge(
  "cassandra.ownership",
  ss.Ownership.get(InetAddress.getByName(localEndpoint)),
-  dims))
-
+  dims))


maybe that change can be reverted

atoulme

LGTM

hughesjj force-pushed the create-pull-request/update-deps branch from 28b501b to 0debbde Compare February 20, 2024 22:50

hughesjj force-pushed the create-pull-request/update-deps branch from 8978236 to 578c15a Compare February 26, 2024 23:55

hughesjj force-pushed the create-pull-request/update-deps branch from 8359560 to 85beb07 Compare February 27, 2024 23:04

hughesjj marked this pull request as ready for review February 27, 2024 23:32

hughesjj requested review from a team as code owners February 27, 2024 23:32

srv-gh-o11y-gdi and others added 20 commits February 29, 2024 14:51

Update OpenTelemetry Dependencies to latest

5d13054

fix gomod at least

13f091d

sync with main and add empty config struct to match new signature for…

d22783b

… expandConverter

regenerate metrics

d455bc0

fix test for discovery bundling

cf59063

re-tidy

8a404b8

fix 'not-real' test given new naming requirements

5b3a3e4

rename class/member for OTLPExporter.Config to align with upstream

98d8148

due to troubles building locally, make attempt to increase/revert tim…

78f7b5f

…eout and build in github

will revert this, plugging away and trying to find bad timeout

f86db52

stash

3ce56ee

stasharoonies

f496644

progress on discovery alignment. Note might be erroneous to remove re…

be10dc3

…ceiver.type from env vars

fix embed tests

b3c1161

enforce MustNew over New in most places

f50f028

Fixes to using MustNewBlah everywhere

7f5569b

rename some files to match receiver names; seed correlations with sen…

f91fc97

…tinel values instead of empty

guard observer types

b856db5

ruhroh

d693bdc

Cleanup debug-mode

3c0db06

hughesjj added 21 commits February 29, 2024 14:57

revert removal of deprecated testcontainer networks for now

1019a4e

try removing networks since that code has been broken upstream for a …

f7a2eb3

…while anyway

missed this network creation request

8285cdb

missed another testcontainers Network

1cc3131

fix test for collector_container

3911d2b

replace deprecated mount syntax

f1515df

commit before revert

8fc8d24

revert commits that would have updated testcontainers-go fallout for …

78bb7bc

…networks

just revert all the testcontianers-go network stuff and ignore the on…

f1a8613

…e file from the troublesome linter (see golangci/golangci-lint#741)

rename this back to original

cb674f0

Revert testcontainers-go to v0.20.1

30091ba

Well this gets the jmx server up again

6ee52f1

more or less fix jmx tests

5f198d1

passes locally

e98fbee

only return if non-empty

a8d4dd1

start skipping tests

aeb4966

batch of skips

38725d0

more test fixes

92e27c4

might as well ANY-ify these

59b1613

skip promlight internal metrics test for now

38c9b9e

tidy gosum

a5dda2e

hughesjj force-pushed the create-pull-request/update-deps branch from b18ce7e to a5dda2e Compare February 29, 2024 23:00

atoulme reviewed Mar 1, 2024

View reviewed changes

atoulme approved these changes Mar 1, 2024

View reviewed changes

hughesjj merged commit 23f9b4b into main Mar 1, 2024
44 checks passed

delete-merged-branch bot deleted the create-pull-request/update-deps branch March 1, 2024 00:11

github-actions bot locked and limited conversation to collaborators Mar 1, 2024

hughesjj self-assigned this Mar 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update OpenTelemetry Dependencies to latest #4275

Update OpenTelemetry Dependencies to latest #4275

srv-gh-o11y-gdi commented Feb 8, 2024

hughesjj commented Feb 21, 2024

hughesjj commented Feb 22, 2024

hughesjj commented Feb 27, 2024

atoulme Mar 1, 2024

crobert-1 Mar 1, 2024

atoulme Mar 1, 2024

atoulme Mar 1, 2024

atoulme left a comment

Update OpenTelemetry Dependencies to latest #4275

Update OpenTelemetry Dependencies to latest #4275

Conversation

srv-gh-o11y-gdi commented Feb 8, 2024

hughesjj commented Feb 21, 2024

hughesjj commented Feb 22, 2024

hughesjj commented Feb 27, 2024

atoulme Mar 1, 2024

Choose a reason for hiding this comment

crobert-1 Mar 1, 2024

Choose a reason for hiding this comment

atoulme Mar 1, 2024

Choose a reason for hiding this comment

atoulme Mar 1, 2024

Choose a reason for hiding this comment

atoulme left a comment

Choose a reason for hiding this comment