Oracledb discovery #3633
Oracledb discovery #3633
Conversation
internal/confmapprovider/discovery/bundle/bundle.d/receivers/oracledb.discovery.yaml.tmpl
Outdated
Show resolved
Hide resolved
internal/confmapprovider/discovery/bundle/bundle.d/receivers/oracledb.discovery.yaml.tmpl
Outdated
Show resolved
Hide resolved
internal/confmapprovider/discovery/bundle/bundle.d/receivers/oracledb.discovery.yaml.tmpl
Outdated
Show resolved
Hide resolved
|
Is this compatible with windows? If so it should be added to https://github.com/signalfx/splunk-otel-collector/blob/main/internal/confmapprovider/discovery/bundle/bundle_windows.go#L30 |
internal/confmapprovider/discovery/bundle/bundle.d/receivers/oracledb.discovery.yaml.tmpl
Show resolved
Hide resolved
internal/confmapprovider/discovery/bundle/bundle.d/receivers/oracledb.discovery.yaml.tmpl
Outdated
Show resolved
Hide resolved
|
Do you mind adding this receiver to the bundled section in https://github.com/signalfx/splunk-otel-collector/blob/main/internal/confmapprovider/discovery/README.md#discovery-mode? |
This comment was marked as outdated.
This comment was marked as outdated.
|
not sure what to make of that lint check failure's output. Definitely lint'd and doing it again doesn't show any changes |
If you rebase/pull in main it should be resolved w/ #3681 |
internal/confmapprovider/discovery/bundle/bundle.d/receivers/oracledb.discovery.yaml.tmpl
Outdated
Show resolved
Hide resolved
Quite welcome and happy to help! Will see about getting other integration discovery going for our other targets. |
|
Thanks @greatestusername and @rmfitzpatrick! |
* update bundled test and configs for oraclediscovery * update bundled test and configs for oraclediscovery * running bundled_test now evaluate metrics matching * add working bundled_test * update fail and partial messages for receiver config variables * order of bundled configs matters * make fmt and add more time * lower durations, add in args for endpoint and service * reduce time on image pull and add to windows bundle * add to bundle_windows_test * lower times on tests * address feedback on yaml template and test using env var * gotta make generate-metrics * re-arrange bundled test * add oracledb to the discovery readme * make generate-metrics fmt * address feedback * Update internal/confmapprovider/discovery/README.md Co-authored-by: Ryan Fitzpatrick <[email protected]> * fix to re-check and other attribute fields * add new test data for bundled test * add generated yaml --------- Co-authored-by: greatestusername-splunk <[email protected]> Co-authored-by: Ryan Fitzpatrick <[email protected]>
Description:
Adds discovery mode tests and configs for
oracledbreceiverLink to Splunk idea:
No idea link. Internal contribution
Testing:
TestOracledbDockerObserverTestOracleDBIntegrationworks as intendedDocumentation:
No new documentation added yet