-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump otel collector contrib dependancy #276
Conversation
f6da1fd
to
f08338c
Compare
Also apply changes to adapt for a breaking change in contrib to custom unmarshalling
Codecov Report
@@ Coverage Diff @@
## main #276 +/- ##
==========================================
- Coverage 86.93% 86.89% -0.04%
==========================================
Files 20 20
Lines 1492 1488 -4
==========================================
- Hits 1297 1293 -4
Misses 160 160
Partials 35 35
Continue to review full report at Codecov.
|
allSettings := componentViperSection.AllSettings() | ||
extensionCfg := intoCfg.(*Config) | ||
func (cfg *Config) Unmarshal(componentParser *config.Parser) error { | ||
allSettings := componentParser.Viper().AllSettings() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't technically a transparent change, but works coincidentally by the default config (intoCfg
) sharing values with config, err := smartAgentConfigFromSettingsMap(allSettings)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm more caught up on the signature/parser changes and see this isn't the case (invocation is about the same https://github.com/open-telemetry/opentelemetry-collector/pull/2867/files#diff-9c00f8edbdec0493154b28fa17b5f69bdcd8097bcf96cd3bd7d664e145c9b8f6R549)
Also apply changes to adapt for a breaking change in contrib to custom unmarshalling
Need to pick up these commits: