Provide informative unsupported monitor error on windows #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
rmfitzpatrick
force-pushed
the
windowscollectdmonitorerror
branch
from
b2498d7
to
60cf682
Compare
rmfitzpatrick
commented
Jan 24, 2022
rmfitzpatrick
force-pushed
the
windowscollectdmonitorerror
branch
from
0e237c1
to
542be16
Compare
tmorrisonsfx
approved these changes
Jan 24, 2022
jvoravong
approved these changes
Jan 27, 2022
pmcollins
approved these changes
Jan 27, 2022
rmfitzpatrick
force-pushed
the
windowscollectdmonitorerror
branch
from
542be16
to
6cea515
Compare
Good suggestion, added one. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing error is vague for windows users who aren't aware that existing platform support is enforced in SA receiver. These changes provide more detail instead of saying the monitor isn't known.