remove extra quote from msi config (#4361)

* remove extra quote from msi config * add changelog
signalfx · Mar 1, 2024 · c605cad · c605cad
1 parent b766592
commit c605cad
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -67,6 +67,7 @@ This Splunk OpenTelemetry Collector release includes changes from the [opentelem
 
 ### 🧰 Bug fixes 🧰
 
+- (Splunk) Fixes the value of a default environment variable used by Windows msi. ([#4361](https://github.com/signalfx/splunk-otel-collector/pull/4361))
 - (Core) `service`: fix opencensus bridge configuration in periodic readers ([#9361](https://github.com/open-telemetry/opentelemetry-collector/pull/9361))
 - (Core) `otlpreceiver`: Fix goroutine leak when GRPC server is started but HTTP server is unsuccessful ([#9165](https://github.com/open-telemetry/opentelemetry-collector/pull/9165))
 - (Core) `otlpexporter`: PartialSuccess is treated as success, logged as warning. ([#9243](https://github.com/open-telemetry/opentelemetry-collector/pull/9243))

diff --git a/internal/buildscripts/packaging/msi/splunk-otel-collector.wxs b/internal/buildscripts/packaging/msi/splunk-otel-collector.wxs
@@ -40,7 +40,7 @@
                      </RegistryKey>
                      <RegistryKey Root="HKLM" Key="SYSTEM\CurrentControlSet\Services\splunk-otel-collector">
                         <RegistryValue Type="multiString" Name="Environment">
-                           <MultiStringValue>SPLUNK_CONFIG=[CommonAppDataFolder]Splunk\OpenTelemetry Collector\agent_config.yaml"</MultiStringValue>
+                           <MultiStringValue>SPLUNK_CONFIG=[CommonAppDataFolder]Splunk\OpenTelemetry Collector\agent_config.yaml</MultiStringValue>
                         </RegistryValue>
                      </RegistryKey>
                   </Component>