Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use signalfx-forwarder in default agent trace pipeline #98

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Use signalfx-forwarder in default agent trace pipeline #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions helm-charts/splunk-otel-collector/templates/config/_otel-agent.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@ receivers:
extra_metadata_labels:
- container.id

smartagent/signalfx-forwarder:
type: signalfx-forwarder
listenAddress: 0.0.0.0:9080

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should listenAddress also be configured to match the default agent config (0.0.0.0:9080)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure tbh since this isn't in the SA config map, but if that's the default everything else uses makes sense.

# By default k8s_tagger and batch processors enabled.
processors:
# k8s_tagger enriches traces and metrics with k8s metadata
Expand Down Expand Up @@ -188,7 +192,7 @@ service:

# default traces pipeline
traces:
receivers: [otlp, jaeger, zipkin]
receivers: [otlp, jaeger, smartagent/signalfx-forwarder, zipkin]
processors:
- memory_limiter
- batch
Expand Down Expand Up @@ -231,7 +235,7 @@ service:
- resource/add_agent_k8s
- resourcedetection
exporters:
# Use signalfx instead of otlp even if collector is enabled
# Use signalfx instead of otlp even if collector is enabled
# in order to sync host metadata.
- signalfx
{{- end }}