Add option to disable ocp scc #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvoravong
reviewed
Jul 18, 2023
|
@gusdebbaja can you add an entry to CHANGELOG.md and make sure it is up to date? |
jvoravong
reviewed
Jul 18, 2023
|
Will this not be merged? |
jvoravong
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when using Openshift platform, the SecurityContextConstraint is deployed by the chart and there is no option to disable it.
This is an issue for users that do not have permissions to deploy SCC resources, so much like ClusterRole resource, the user should have the option not to deploy this resource.
This helm chart deploys and no SCC resource is created.