runAsUser SecurityContext not working for windows #797
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on kubernetes/kubernetes#102849 runAsUser is not currently working for windows.
This prevents the agent from starting
This PR checks if
runAsUser
is defined in the securityContext for a windows agent, cluster-receiver and gateway and remove it if it exists.Finally, I have noticed that
revert-patch-log-dirs-hook.yaml
is rendered for windows whensecurityContext.runAsUser
andsecurityContext.runAsGroup
are defined, althoughrunAsUser
does not work on windows, I aded an extra check to make sure not to bother when it's windows.Note: I still need to do more validation and testing as we changed some requirements. Still need to recover Fluentd and use the helper in other places