Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change networkExplorer.kernelCollector.useDockerMetadata default value to false. #665

Merged
merged 2 commits into from
Feb 10, 2023
+2 −10
Merged

Change networkExplorer.kernelCollector.useDockerMetadata default value to false. #665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b931c45
Change networkExplorer.kernelCollector.useDockerMetadata default valu…
jmw51798 Feb 9, 2023
476f064
Make render changes.
jmw51798 Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions ...able-network-explorer/rendered_manifests/network-explorer/kernel-collector-daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ spec:
imagePullPolicy: Always
args:
- --config-file=/etc/network-explorer/config.yaml
- --force-docker-metadata
- --disable-nomad-metadata
- --warning
# TODO: liveness probe
Expand Down Expand Up @@ -69,9 +68,6 @@ spec:
- mountPath: /etc/network-explorer
name: default-splunk-otel-collector-config
readOnly: true
- mountPath: /var/run/docker.sock
name: docker-sock
readOnly: false
dnsPolicy: ClusterFirstWithHostNet
hostNetwork: true
hostPID: true
Expand All @@ -93,10 +89,6 @@ spec:
hostPath:
path: /var/cache
type: DirectoryOrCreate
- name: docker-sock
hostPath:
path: /var/run/docker.sock
type: Socket
tolerations:
- effect: NoExecute
operator: Exists
Expand Down
4 changes: 2 additions & 2 deletions helm-charts/splunk-otel-collector/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1126,8 +1126,8 @@ networkExplorer:
# uncomment the line below to disable automatic kernel headers fetching
# fetchKernelHeaders: false

# assumes docker is being used for kubernetes containers
useDockerMetadata: true
# uncomment to enable enrichment using Docker metadata
# useDockerMetadata: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply changed the default value for NetworkExplorer useDockerMetadata. (It defaults to false here: https://github.com/jimwsplk/splunk-otel-collector-chart/blob/main/helm-charts/splunk-otel-collector/templates/network-explorer/kernel-collector-daemonset.yaml#L46)

Tested and validated deploying with this change in my dev environment.


# uncomment to enable enrichment using Nomad metadata (https://www.nomadproject.io/)
# collectNomadMetadata: true
Expand Down