Add splunk-otel-collector secret to cluster receiver #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
reviewed
Feb 28, 2022
| @@ -1,6 +1,6 @@ | |||
| apiVersion: v2 | |||
| name: splunk-otel-collector | |||
| version: 0.43.4 | |||
| version: 0.43.5 | |||
There was a problem hiding this comment.
If you want to release it right away, please add a section to CHANGELOG and run make render
There was a problem hiding this comment.
Feel free to keep the current version. we will release it after
I think it's also missed in gateway-deployment.yaml |
I've added it to gateway-deployment.yaml as well and ran |
Prior to this fix the cluster receiver wouldn't start because it was looking for the CA, but as it was not mounted it failed to start the process.
tongpu
force-pushed
the
bug/add-cafile-to-cluster-receiver
branch
from
c19d6e0 to
9c5d830
Compare
dmitryax
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this fix the cluster receiver wouldn't start because it was looking for the CA, but as it was not mounted it failed to start the process.
Would there be any other places where this might need to be added?