Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add eks/fargate distribution with 2-replica StatefulSet #346

Merged
merged 14 commits into from
Feb 1, 2022

Conversation

rmfitzpatrick
Copy link
Contributor

@rmfitzpatrick rmfitzpatrick commented Jan 6, 2022

Please do not merge until Splunk distribution has updated k8s_observer and receiver creator components

These changes introduce a new eks/fargate distribution option that adds a receiver creator-controlled kubelet stats receiver to the cluster receiver deployment, as well as a new "cluster receiver observer" deployment to report that collector's kubelet stats metrics since the cluster receiver cannot reach its own kubelet. I chose this dual collector approach over adding the applicable observer/receiver pair to the existing gateway config because there was no clear way to limit discovery to a single gateway* replica and having multiple gateways would lead to redundant metrics (it's also not guaranteed people will use a gateway).

Please see the updated advanced configuration section for a bit more detail.

edit: from @dmitryax's suggestion* I've updated this to be a 2-replica StatefulSet with the same functionality, and pod name based init container logic for node labeling and stripping the cluster receiver on one pod.

@rmfitzpatrick rmfitzpatrick requested review from a team as code owners January 6, 2022 20:17
@rmfitzpatrick rmfitzpatrick force-pushed the eksfargate branch 5 times, most recently from 2871834 to d0ba523 Compare January 6, 2022 21:08
@rmfitzpatrick rmfitzpatrick force-pushed the eksfargate branch 3 times, most recently from e4dc5ff to b0c6c4d Compare January 21, 2022 18:06
@rmfitzpatrick rmfitzpatrick changed the title DRAFT: add eks/fargate distribution with cluster-receiver-observer deployment add eks/fargate distribution with cluster-receiver-observer deployment Jan 26, 2022
@rmfitzpatrick rmfitzpatrick changed the title add eks/fargate distribution with cluster-receiver-observer deployment add eks/fargate distribution with 2-replica StatefulSet Jan 26, 2022
@jek-bao-choo
Copy link

@dmitryax and @rmfitzpatrick Thank you for this support :)

@rmfitzpatrick rmfitzpatrick force-pushed the eksfargate branch 3 times, most recently from 4d2258c to 7b060ca Compare January 31, 2022 18:22
@rmfitzpatrick
Copy link
Contributor Author

rmfitzpatrick commented Feb 1, 2022

re: #346 (comment)

I wasn't able to get nested templates to work (unexpected <define> in command) and thought named templates needed to be defined in .tpl, but what I have now seems to allow a multiline string variable* definition.

@rmfitzpatrick rmfitzpatrick merged commit 6c43a40 into main Feb 1, 2022
@rmfitzpatrick rmfitzpatrick deleted the eksfargate branch February 1, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants