-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add eks/fargate distribution with 2-replica StatefulSet #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmfitzpatrick
force-pushed
the
eksfargate
branch
5 times, most recently
from
January 6, 2022 21:08
2871834
to
d0ba523
Compare
dmitryax
reviewed
Jan 7, 2022
...harts/splunk-otel-collector/templates/config/_otel-eks-fargate-cluster-receiver-observer.tpl
Outdated
Show resolved
Hide resolved
dmitryax
reviewed
Jan 7, 2022
helm-charts/splunk-otel-collector/templates/config/_otel-k8s-cluster-receiver-config.tpl
Show resolved
Hide resolved
rmfitzpatrick
force-pushed
the
eksfargate
branch
from
January 7, 2022 21:39
d0ba523
to
8d5b3e7
Compare
rmfitzpatrick
force-pushed
the
eksfargate
branch
2 times, most recently
from
January 20, 2022 19:57
f30c258
to
ba61763
Compare
dmitryax
reviewed
Jan 21, 2022
helm-charts/splunk-otel-collector/templates/deployment-cluster-receiver.yaml
Outdated
Show resolved
Hide resolved
helm-charts/splunk-otel-collector/templates/deployment-cluster-receiver.yaml
Outdated
Show resolved
Hide resolved
rmfitzpatrick
force-pushed
the
eksfargate
branch
3 times, most recently
from
January 21, 2022 18:06
e4dc5ff
to
b0c6c4d
Compare
dmitryax
reviewed
Jan 26, 2022
helm-charts/splunk-otel-collector/templates/deployment-cluster-receiver.yaml
Outdated
Show resolved
Hide resolved
helm-charts/splunk-otel-collector/templates/deployment-cluster-receiver.yaml
Outdated
Show resolved
Hide resolved
helm-charts/splunk-otel-collector/templates/deployment-cluster-receiver.yaml
Outdated
Show resolved
Hide resolved
helm-charts/splunk-otel-collector/scripts/lookup-eks-fargate-receiver-node.sh
Outdated
Show resolved
Hide resolved
helm-charts/splunk-otel-collector/scripts/lookup-eks-fargate-receiver-node.sh
Outdated
Show resolved
Hide resolved
rmfitzpatrick
changed the title
DRAFT: add eks/fargate distribution with cluster-receiver-observer deployment
add eks/fargate distribution with cluster-receiver-observer deployment
Jan 26, 2022
rmfitzpatrick
force-pushed
the
eksfargate
branch
from
January 26, 2022 17:16
b0c6c4d
to
e3ed6d4
Compare
dmitryax
reviewed
Jan 26, 2022
helm-charts/splunk-otel-collector/scripts/lookup-eks-fargate-receiver-node.sh
Outdated
Show resolved
Hide resolved
helm-charts/splunk-otel-collector/scripts/lookup-eks-fargate-receiver-node.sh
Outdated
Show resolved
Hide resolved
rmfitzpatrick
changed the title
add eks/fargate distribution with cluster-receiver-observer deployment
add eks/fargate distribution with 2-replica StatefulSet
Jan 26, 2022
@dmitryax and @rmfitzpatrick Thank you for this support :) |
dmitryax
reviewed
Jan 27, 2022
rendered/manifests/eks-fargate/configmap-cluster-receiver-node-discoverer-script.yaml
Outdated
Show resolved
Hide resolved
helm-charts/splunk-otel-collector/templates/config/_otel-k8s-cluster-receiver-config.tpl
Show resolved
Hide resolved
dmitryax
reviewed
Jan 27, 2022
helm-charts/splunk-otel-collector/templates/config/_otel-k8s-cluster-receiver-config.tpl
Outdated
Show resolved
Hide resolved
rendered/manifests/eks-fargate/configmap-cluster-receiver-node-discoverer-script.yaml
Outdated
Show resolved
Hide resolved
dmitryax
reviewed
Jan 27, 2022
helm-charts/splunk-otel-collector/templates/deployment-cluster-receiver.yaml
Outdated
Show resolved
Hide resolved
dmitryax
reviewed
Jan 27, 2022
rmfitzpatrick
force-pushed
the
eksfargate
branch
3 times, most recently
from
January 31, 2022 18:22
4d2258c
to
7b060ca
Compare
rmfitzpatrick
commented
Jan 31, 2022
helm-charts/splunk-otel-collector/templates/config/_otel-k8s-cluster-receiver-config.tpl
Outdated
Show resolved
Hide resolved
rmfitzpatrick
force-pushed
the
eksfargate
branch
from
January 31, 2022 20:25
517cbbc
to
c8c7c43
Compare
dmitryax
reviewed
Feb 1, 2022
helm-charts/splunk-otel-collector/templates/config/_otel-k8s-cluster-receiver-config.tpl
Outdated
Show resolved
Hide resolved
helm-charts/splunk-otel-collector/templates/deployment-cluster-receiver.yaml
Outdated
Show resolved
Hide resolved
helm-charts/splunk-otel-collector/templates/configmap-gateway.yaml
Outdated
Show resolved
Hide resolved
re: #346 (comment) I wasn't able to get nested templates to work ( |
rmfitzpatrick
force-pushed
the
eksfargate
branch
from
February 1, 2022 15:31
527260d
to
8380a9b
Compare
dmitryax
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not merge until Splunk distribution has updated k8s_observer and receiver creator componentsThese changes introduce a new
eks/fargate
distribution option that adds a receiver creator-controlled kubelet stats receiver to the cluster receiver deployment, as well as a new "cluster receiver observer" deployment to report that collector's kubelet stats metrics since the cluster receiver cannot reach its own kubelet. I chose this dual collector approach over adding the applicable observer/receiver pair to the existing gateway config because there was no clear way to limit discovery to a single gateway* replica and having multiple gateways would lead to redundant metrics (it's also not guaranteed people will use a gateway).Please see the updated advanced configuration section for a bit more detail.
edit: from @dmitryax's suggestion* I've updated this to be a 2-replica StatefulSet with the same functionality, and pod name based init container logic for node labeling and stripping the cluster receiver on one pod.