add support for tailing custom host files #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockb1017
force-pushed
the
customFiles
branch
from
e28270c to
f0b9a23
Compare
dmitryax
reviewed
Nov 18, 2021
| @@ -394,6 +394,21 @@ logsCollection: | |||
|
|
|||
| checkpointPath: "/var/addon/splunk/otel_pos" | |||
|
|
|||
| # Files on k8s nodes to tail. | |||
| # Make sure to configure volume mounts properly at `otelAgent.extraVolumes` and `otelAgent.extraVolumeMounts`. | |||
| extraFileLogs: {} | |||
There was a problem hiding this comment.
An example of how to use volumes/emptydir would be nice to have!
There was a problem hiding this comment.
This should go to examples https://github.com/signalfx/splunk-otel-collector-chart/tree/main/examples, and this values.yaml comment can get a link to it. Just to avoid mixing comment for different config parts here.
There was a problem hiding this comment.
I'd recommend submit another PR for that. This one LGTM. Let me know if we shold merge it
There was a problem hiding this comment.
Yeah, its cool to merge it.
There was a problem hiding this comment.
Ok, added issue for this #307
rockb1017
force-pushed
the
customFiles
branch
from
f0b9a23 to
df19d18
Compare
dmitryax
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to pick up logs on emptydir or a filemount ( non stderr/stdout logs, stuck in container filesystem or audit log etc)