-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add initContainer for running as non root user #263
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockb1017
force-pushed
the
nonRoot
branch
3 times, most recently
from
November 2, 2021 15:19
ec36a2e
to
e529aef
Compare
rockb1017
changed the title
add initContainer for running as non root user
[draft] add initContainer for running as non root user
Nov 2, 2021
rockb1017
changed the title
[draft] add initContainer for running as non root user
add initContainer for running as non root user
Nov 2, 2021
tmorrisonsfx
reviewed
Nov 2, 2021
@tmorrisonsfx Could you re-review? thanks! |
tmorrisonsfx
approved these changes
Nov 12, 2021
Done! Thanks. |
dmitryax
reviewed
Nov 15, 2021
dmitryax
reviewed
Nov 15, 2021
dmitryax
reviewed
Nov 15, 2021
helm-charts/splunk-otel-collector/ci/logs-only-otel-se-o11y-values.yaml
Outdated
Show resolved
Hide resolved
rockb1017
force-pushed
the
nonRoot
branch
3 times, most recently
from
November 16, 2021 22:23
bd0a25e
to
9df2614
Compare
dmitryax
reviewed
Nov 17, 2021
rockb1017
force-pushed
the
nonRoot
branch
3 times, most recently
from
November 19, 2021 05:41
8677fc8
to
38e0474
Compare
dmitryax
reviewed
Nov 19, 2021
dmitryax
approved these changes
Nov 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.