Simplify logic identifying which destination is enabled #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use only `splunkPlatform.endpoint` and `splunkObservability.realm` parameters to identify which destination is enabled, remove default value for `splunkObservability.realm`
dmitryax
changed the title
rmfitzpatrick
approved these changes
Oct 18, 2021
dmitryax
added a commit
that referenced
this pull request
Oct 18, 2021
Enabled destination is now identified only based on `realm` and `endpoint` sub-properties: #230. This change updates missed helpers according to the new behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use only
splunkPlatform.endpointandsplunkObservability.realmparameters to identify which destination is enabled, remove default value forsplunkObservability.realm