Fix container runtime detection when metrics collection disabled #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
logs-only
branch
2 times, most recently
from
97a1324 to
243b9d6
Compare
dmitryax
force-pushed
the
logs-only
branch
2 times, most recently
from
3409308 to
ed1037c
Compare
Don't use hostfs volume for container runtime detection, since it's needed for logs only and hostfs volume not created for logs pipeline.
dmitryax
changed the title
jrcamp
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use hostfs volume for container runtime detection, since it's needed for logs only and hostfs volume not created for logs pipeline.