agent: support discovery mode on linux #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmfitzpatrick
force-pushed
the
discoverymode
branch
from
01ebcfa to
8309f4d
Compare
rmfitzpatrick
force-pushed
the
discoverymode
branch
from
8309f4d to
9f68aa6
Compare
jvoravong
reviewed
Jan 8, 2024
jvoravong
reviewed
Jan 8, 2024
jvoravong
reviewed
Jan 8, 2024
Co-authored-by: jvoravong <[email protected]>
Co-authored-by: jvoravong <[email protected]>
jvoravong
approved these changes
Jan 9, 2024
dmitryax
approved these changes
Jan 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding a feature - These changes adopt discovery mode for agents, configurable with a new
agent.discoveryvalue mapping (disabled by default).Right now only an
enabledvalue andextensionsandreceiversproperties are configurable. I originally planned on adding adurationfield that will influence theSPLUNK_DISCOVERY_DURATIONenv var, but decided to defer for a followup since the liveness/readiness probeinitialDelaySecondswould also need to be adjusted.Testing:
My plan is for the integration tests be in the SOC project where the feature exists, with initial "test" being pushed implicitly to the example yaml content (and lack of changes in others).
Documentation:
Updated advanced configuration doc.