Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hostNetwork as variable #1107

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Add hostNetwork as variable #1107

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0153ee9
fix: add hostNetwork as variable
ajasnosz Jan 3, 2024
53768cb
chore: update changelog
ajasnosz Jan 5, 2024
dba1aea
chore: move hostnetwork to agent
ajasnosz Jan 9, 2024
ffc2ffe
chore: specify dnspolicy
ajasnosz Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .chloggen/sethostnetwork.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement
# The name of the component, or a single word describing the area of concern, (e.g. agent, clusterReceiver, gateway, operator, chart, other)
component: chart
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Allows to set the hostNetwork parameter in chart
# One or more tracking issues related to the change
issues: [1014]
# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
2 changes: 1 addition & 1 deletion helm-charts/splunk-otel-collector/templates/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ spec:
sidecar.istio.io/inject: "false"
{{- end }}
spec:
{{- if not .Values.isWindows }}
{{- if and (.Values.hostNetwork) (not .Values.isWindows)}}
rmfitzpatrick marked this conversation as resolved.
Show resolved Hide resolved
hostNetwork: true
{{- end }}
dnsPolicy: ClusterFirstWithHostNet
rmfitzpatrick marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
4 changes: 4 additions & 0 deletions helm-charts/splunk-otel-collector/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@
"description": "Cluster name that will be used as metadata attributes for all telemetry data",
"type": "string"
},
"hostNetwork": {
"description": "Host network allows container to use networking stack of the host machine",
"type": "boolean"
},
"splunkPlatform": {
"description": "Splunk Cloud / Splunk Enterprise configuration",
"type": "object",
Expand Down
8 changes: 8 additions & 0 deletions helm-charts/splunk-otel-collector/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,14 @@ fullnameOverride: ""

clusterName: ""

################################################################################
# hostNetwork is an option that allows to use the networking stack of the host
# machine. Disabling this value will have affect on monitoring some control
# plane components. For Windows operating system the hostNetwork is disabled.
################################################################################

hostNetwork: true
ajasnosz marked this conversation as resolved.
Show resolved Hide resolved

################################################################################
# Splunk Cloud / Splunk Enterprise configuration.
################################################################################
Expand Down
Loading