Skip to content

Commit

Permalink
Fix autopilot deployment by removing the metrics-addr workaround
Browse files Browse the repository at this point in the history
The metrics workaround added for GKE Autopilot is not needed anymore. It was fixed on GKE side in a way that it's required to remove it.
  • Loading branch information
dmitryax committed Feb 21, 2024
1 parent 8d0f489 commit ef59d7d
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
8 changes: 8 additions & 0 deletions .chloggen/fix-autopilot-deployment.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: bug_fix
# The name of the component, or a single word describing the area of concern, (e.g. agent, clusterReceiver, gateway, operator, chart, other)
component: agent
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Fix GKE Autopilot deployment
# One or more tracking issues related to the change
issues: [1171]
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ spec:
command:
- /otelcol
- --config=/conf/relay.yaml
- --metrics-addr=0.0.0.0:8889
ports:
- name: jaeger-grpc
containerPort: 14250
Expand Down
4 changes: 0 additions & 4 deletions helm-charts/splunk-otel-collector/templates/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -248,10 +248,6 @@ spec:
{{- else }}
- /otelcol
- --config=/conf/relay.yaml
{{- if eq .Values.distribution "gke/autopilot" }}
{{- /* Temporary no-op argument required to run collector on GKE Autopilot */}}
- --metrics-addr=0.0.0.0:8889
{{- end }}
{{- end }}
{{- if .Values.agent.featureGates }}
- --feature-gates={{ .Values.agent.featureGates }}
Expand Down

0 comments on commit ef59d7d

Please sign in to comment.