Skip to content

Commit

Permalink
Remove redundant arguments to otelMemoryLimiterConfig helper (#324)
Browse files Browse the repository at this point in the history
The helper used to receive specific component resources as argument to calculate memory limit. This is not needed anymore since calculation was moved to the image itself
  • Loading branch information
dmitryax authored Nov 30, 2021
1 parent dcdea8d commit 4089304
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ Config for the otel-collector agent
The values can be overridden in .Values.agent.config
*/}}
{{- define "splunk-otel-collector.agentConfig" -}}
{{ $agent := fromYaml (include "splunk-otel-collector.agent" .) -}}
{{ $gateway := fromYaml (include "splunk-otel-collector.gateway" .) -}}
extensions:
{{- if and (eq (include "splunk-otel-collector.logsEnabled" .) "true") (eq .Values.logsEngine "otel") }}
Expand Down Expand Up @@ -317,7 +316,7 @@ processors:
{{- include "splunk-otel-collector.filterLogsProcessors" . | nindent 2 }}
{{- end }}
{{- include "splunk-otel-collector.otelMemoryLimiterConfig" $agent | nindent 2 }}
{{- include "splunk-otel-collector.otelMemoryLimiterConfig" . | nindent 2 }}
batch:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ Config for the optional standalone collector
The values can be overridden in .Values.gateway.config
*/}}
{{- define "splunk-otel-collector.gatewayConfig" -}}
{{ $gateway := fromYaml (include "splunk-otel-collector.gateway" .) -}}
extensions:
health_check:

Expand Down Expand Up @@ -78,7 +77,7 @@ processors:
{{- include "splunk-otel-collector.resourceLogsProcessor" . | nindent 2 }}
{{- include "splunk-otel-collector.filterLogsProcessors" . | nindent 2 }}

{{- include "splunk-otel-collector.otelMemoryLimiterConfig" $gateway | nindent 2 }}
{{- include "splunk-otel-collector.otelMemoryLimiterConfig" . | nindent 2 }}

batch:

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ receivers:
{{- end }}

processors:
{{- include "splunk-otel-collector.otelMemoryLimiterConfig" $clusterReceiver | nindent 2 }}
{{- include "splunk-otel-collector.otelMemoryLimiterConfig" . | nindent 2 }}

batch:

Expand Down

0 comments on commit 4089304

Please sign in to comment.