Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial experimental support for OTLP export. #788

Merged
merged 9 commits into from
Apr 1, 2024

Conversation

breedx-splk
Copy link
Contributor

Adds initial support for OTLP export from Splunk Android RUM instrumentation. This is not enabled by default, and is currently incompatible with the disk buffering feature. As such, if disk buffering is abled, OTLP exporting will not work and a warning will be logged.

There are not yet any beacon endpoints that will correctly handle this data anyway, but a collector can be used to inspect the payloads.

@breedx-splk breedx-splk requested review from a team as code owners March 28, 2024 23:21

@NonNull
private Supplier<SpanExporter> supplyOtlpExporter() {
// TODO: Do we want/need to append the auth query parameter like zipkin?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably this will get nailed down as we collaborate with the backend team?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I got confirmation today that it works the same way, so I should update this. How about I do it in a follow-up PR?

@breedx-splk breedx-splk merged commit 877e3e5 into signalfx:main Apr 1, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants