Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.14.0 pre release changes #279

Merged
merged 2 commits into from
May 2, 2022
Merged

Conversation

agoallikmaa
Copy link
Contributor

No description provided.

@agoallikmaa agoallikmaa requested review from a team as code owners April 22, 2022 10:00
Copy link
Contributor

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to wait for #276 -- which in turn waits for the instrumentation 1.13.1 patch release.

README.md Outdated
@@ -117,7 +117,7 @@ Then, add the locally built library as a dependency in your application's build.
```
dependencies {
...
implementation ("com.splunk:splunk-otel-android:0.14.0-SNAPSHOT")
implementation ("com.splunk:splunk-otel-android:0.14.0")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is about the local build, it's still going to be 0.14.0-SNAPSHOT

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed back. On last release this was changed in pre and back in post, I guess that was unintended there then.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, most likely that was a mistake

@mateuszrzeszutek
Copy link
Contributor

@agoallikmaa please rebase with the main branch - #276 was merged, we can continue the release.

@agoallikmaa agoallikmaa merged commit 0e50d5e into signalfx:main May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants