Added new Logger implementation #1113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Chladek <[email protected]>
|
All contributors have signed the CLA ✍️ ✅ |
|
@TomasChladekSL The build fails, probably because it does not know where to get the logger dependency. |
|
I have read the CLA Document and I hereby sign the CLA |
srv-gh-o11y-gdi-cla
added a commit
to splunk/cla-agreement
that referenced
this pull request
Dec 12, 2024
Signed-off-by: Tomas Chladek <[email protected]>
Signed-off-by: Tomas Chladek <[email protected]>
keciman
approved these changes
Dec 18, 2024
surbhiia
reviewed
Dec 18, 2024
| const val materialIconsExtended = "androidx.compose.material:material-icons-extended:$materialVersion" | ||
| const val animation = "androidx.compose.animation:animation:$version" | ||
|
|
||
| object SessionReplay { |
There was a problem hiding this comment.
nit: Should we name it to a generic word like "common" instead of "SessionReplay"?
There was a problem hiding this comment.
No, because it is part of session replay "package" and all modules must have the same version.
Signed-off-by: Tomas Chladek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unused dependencies
Added Logger