Hook up an OkHttp Dispatcher to propagate context into calls. #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
approved these changes
Aug 6, 2021
|
Just as an FYI... even though this is a safe usage in the demo app, it may not be safe in general, due the way that okhttp queues calls under high load. Mis-parenting of spans probably isn't a huge deal in Android, but I'm going to be working on some better approaches to doing this in opentelemetry-java-instrumentation and will probably use this example as the way to experiment with those better approaches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the demo app, it's nice to demonstrate how to get span-causality for http calls.