This repository has been archived by the owner on Dec 19, 2022. It is now read-only.
Support pip 19+ #17
Merged
Support pip 19+ #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpetazzoni
approved these changes
Feb 2, 2019
|
There are too many Here is a corresponding PR: #19 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pip 19+ has removed dependency link support: https://pip.pypa.io/en/stable/news/#id4
These changes continue adopting the paths suggested in pypa/pip#4187 (for which I had lost the timeline) and move to full PEP 508 usage with the versioned egg approach for environments with pip 18+. They should be transparent to pip 10 users where
--process-dependency-linksis still needed.Adding test coverage for this put tox to its limit w/ configurability, even when considering the perfectly timed https://github.com/pglass/tox-pip-version. These changes move our tox adoption to nox, which proved easier to use with minor performance impacts.