-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify default sampler #284
base: main
Are you sure you want to change the base?
Conversation
Wouldn't changing the default be a breaking change for a distribution? I see it as a breaking change from semantic point of view. If we change the default in Node.js, .NET, Python distributions then I would advise to bump the major version. |
In which distros this is marked as stable? |
So it seems to me that we should prep for the major bump and if possible bundle it up with other changes e.g. HTTP semantics :) for .NET and for Python as well. If there are other major changes that we would like to do let's use this as opportunity to do so. We would target such changes for the Jan-Feb next year though |
Co-authored-by: Piotr Kiełkowicz <[email protected]>
OpenTelemetry defaults to
parentbased_always_on
, but this is not consistent across our distributions:parentbased_always_on
is used by Node.js, .NET, Pythonalways_on
is used by Java, GoIf we are advertising as a no sampling solution, we should default to
always_on
, but still allow for customers to change it.Using
parentbased_always_on
can cause data loss if customers have previously set up cloud tracing, which injects atraceparent
with00
fortraceflags
.