Update repository permissions and log message when service name is no…

…t set (#252)
signalfx · Sep 6, 2023 · 44d7cfb · 44d7cfb
1 parent 6ce6291
commit 44d7cfb
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/specification/configuration.md b/specification/configuration.md
@@ -214,8 +214,8 @@ are required.
     name or link to relevant documentation. E.g.
 
     ```txt
-    service.name attribute is not set, your service is unnamed and will be difficult to identify.
-    set your service name using the OTEL_SERVICE_NAME environment variable.
+    The service.name resource attribute is not set. Your service is unnamed and will be difficult to identify.
+    Set your service name using the OTEL_SERVICE_NAME or OTEL_RESOURCE_ATTRIBUTES environment variable.
     E.g. `OTEL_SERVICE_NAME="<YOUR_SERVICE_NAME_HERE>"`
     ```
 

diff --git a/specification/repository.md b/specification/repository.md
@@ -22,12 +22,10 @@ approval is granted, GDI repositories MUST NOT cut a GA release.
 
 - MUST grant `Admin` [permission
   level](https://docs.github.com/en/organizations/managing-access-to-your-organizations-repositories/repository-permission-levels-for-an-organization)
-  to maintainers team
+  to maintainers team and the `gdi-instrumentation-admins` team
 - MUST grant `Write` [permission
   level](https://docs.github.com/en/organizations/managing-access-to-your-organizations-repositories/repository-permission-levels-for-an-organization)
-  to approvers team and the `signalfx/docs`,
-  `signalfx/gdi-specification-approvers`
-   `signalfx/gdi-specification-maintainers` teams
+  to approvers team and the `signalfx/gdi-docs` team
 - MUST NOT grant `Write`, `Maintain`, `Admin` [permission
   level](https://docs.github.com/en/organizations/managing-access-to-your-organizations-repositories/repository-permission-levels-for-an-organization)
   to any other team

diff --git a/specification/templates/.github/CODEOWNERS b/specification/templates/.github/CODEOWNERS
@@ -14,4 +14,4 @@
 *.md    @signalfx/gdi-TEAM-maintainers @signalfx/gdi-TEAM-approvers @signalfx/gdi-docs
 *.rst   @signalfx/gdi-TEAM-maintainers @signalfx/gdi-TEAM-approvers @signalfx/gdi-docs
 docs/   @signalfx/gdi-TEAM-maintainers @signalfx/gdi-TEAM-approvers @signalfx/gdi-docs
-README* @signalfx/gdi-TEAM-maintainers @signalfx/gdi-TEAM-approvers @signalfx/gdi-docs @signalfx/gdi-specification-approvers @signalfx/gdi-specification-maintainers
+README* @signalfx/gdi-TEAM-maintainers @signalfx/gdi-TEAM-approvers @signalfx/gdi-docs