Skip to content
This repository has been archived by the owner on Aug 5, 2021. It is now read-only.

always pass the full address to isTrustedIdentity #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sualko
Copy link

@sualko sualko commented Jun 28, 2018

For consistency with loadIdentityKey and saveIdentity. See also 1fe18c3.

This is quite important in the OMEMO use case.

For consistency with loadIdentityKey and saveIdentity. See also 1fe18c3.
@scottnonnenberg-signal
Copy link
Contributor

What's the OMEMO use case?

@sualko
Copy link
Author

sualko commented Jun 28, 2018

To be precise, I think this is important in the OMEMO use case, because an identity key is not shared between devices but every device has his own key. Therefor you can not distinguish between different devices if only the address name (which is the jabber id in my implementation) is passed to isTrustedIdentity.

@sualko
Copy link
Author

sualko commented Jul 3, 2018

I found a workaround for my setup, but I still think it makes sense to merge the pr for consistency reasons.

@scottnonnenberg-signal
Copy link
Contributor

Again, what is OMEMO?

@jcbrand
Copy link

jcbrand commented Jul 4, 2018

@scottnonnenberg OMEMO is an encryption protocol for XMPP which uses the SignalProtocol.

https://xmpp.org/extensions/xep-0384.html

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants