Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix proxying of Giphy requests. #2676

Merged
merged 2 commits into from
Oct 20, 2017
Merged

Fix proxying of Giphy requests. #2676

merged 2 commits into from
Oct 20, 2017

Conversation

charlesmchen
Copy link
Contributor

michaelkirk
michaelkirk approved these changes Oct 20, 2017
View reviewed changes
Copy link
Contributor

@michaelkirk michaelkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIOLI, but since this is kind of touchy can we extract and reuse in both places?

LGTM

@charlesmchen
Respond to CR.
c11b82b 
// FREEBIE
@charlesmchen
Copy link
Contributor Author

TIOLI, but since this is kind of touchy can we extract and reuse in both places?

Done.

@charlesmchen charlesmchen merged commit c11b82b into release/2.18.0 Oct 20, 2017
@charlesmchen charlesmchen deleted the charlesmchen/gifProxy branch October 20, 2017 20:22
@pickypg pickypg mentioned this pull request Jul 22, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelkirk michaelkirk michaelkirk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlesmchen @michaelkirk