Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all closing PHP tags #50

Closed
nilportugues opened this issue Jan 24, 2014 · 4 comments
Closed

Remove all closing PHP tags #50

nilportugues opened this issue Jan 24, 2014 · 4 comments

Comments

@nilportugues
Copy link
Contributor

I believe all old and refactored PHP files need the closing php tags ?> removed.

How do you all feel about it?

@alexgt9
Copy link
Member

alexgt9 commented Jan 24, 2014

I agree with that. Also it's not the psr standards
El 24/01/2014 12:25, "Nil Portugués Calderó" [email protected]
escribió:

I believe all old and refactored PHP files need the closing php tags ?>
removed.

How do you all feel about it?


Reply to this email directly or view it on GitHubhttps://github.com//issues/50
.

@alombarte
Copy link
Contributor

No closing tags should exist. If any is in the code it's because we don't have precommit hook, but the old commiters are aware of this—
Sent from Mailbox for iPhone

On Fri, Jan 24, 2014 at 12:32 PM, alexgt9 [email protected]
wrote:

I agree with that. Also it's not the psr standards
El 24/01/2014 12:25, "Nil Portugués Calderó" [email protected]
escribió:

I believe all old and refactored PHP files need the closing php tags ?>
removed.

How do you all feel about it?


Reply to this email directly or view it on GitHubhttps://github.com//issues/50
.


Reply to this email directly or view it on GitHub:
#50 (comment)

@nilportugues
Copy link
Contributor Author

Fixed for sifo3-beta branch. Closing task :)

@alombarte
Copy link
Contributor

Nice, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants