SiFive: Add -z force-zicfilp option #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Internal Jira: SCT-3082 |
|
Oh I need to change |
Add .ifdef in assembly code to control whether we want to add landing pad or shadow stack GNU properties.
hau-hsu
force-pushed
the
dev/hauh/add-force-zicfilp
branch
2 times, most recently
from
eccfb45 to
b79b8c1
Compare
kito-cheng
approved these changes
Oct 26, 2023
bfd/elfxx-riscv.h
Outdated
| typedef enum | ||
| { | ||
| PLT_NORMAL = 0x0, /* Normal plts. */ | ||
| PLT_ZICFILP = 0x1 /* Landing pad plts. */ |
There was a problem hiding this comment.
also, maybe align like that:
PLT_NORMAL = 0x0, /* Normal plts. */
PLT_ZICFILP = 0x1 /* Landing pad plts. */
bfd/elfxx-riscv.c
Outdated
| @@ -2751,7 +2751,7 @@ _bfd_riscv_elf_link_setup_gnu_properties (struct bfd_link_info *info, | |||
| uint32_t *and_prop_p, uint32_t *or_prop_p) | |||
| { | |||
| asection *sec; | |||
| bfd *pbfd; | |||
| bfd *pbfd; /* pointer bfd */ | |||
There was a problem hiding this comment.
Should we really need this comment?
bfd/elfnn-riscv.c
Outdated
| @@ -184,6 +184,13 @@ struct _bfd_riscv_elf_obj_tdata | |||
|
|
|||
| /* All GNU_PROPERTY_RISCV_FEATURE_2_OR properties. */ | |||
| uint32_t gnu_or_prop; | |||
|
|
|||
| /* True to warn when linking objects with incompatible | |||
| GNU_PROPERTY_RISCV_FEATURE_1_ZICFILP. */ | |||
hau-hsu
force-pushed
the
dev/hauh/add-force-zicfilp
branch
from
b79b8c1 to
89dd467
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.