Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add offset option to freedom-bin2hex script for supporting SPI flash #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kenzhang82
Copy link

In freedom e310 arty kit, the bootROM doesn't jump to the base address of the SPI flash address, but with an offset, add the offset option such that 0's are prepend.

@kenzhang82
Copy link
Author

@palmer-dabbelt can you please review this?

@bsousi5
Copy link
Collaborator

bsousi5 commented Apr 13, 2020

An issue with this approach, is you will overwrite the existing contents prior to you program offset.
Consider the following;

[---------------- FLASH MEMORY ------------------------]
| [ FPGA bits ] -- [ BootROM ] --- [ User Program ] ---|
[------------------------------------------------------]

Prepend with leading 0s will overwrite the FPGA bits region

@nategraff-sifive
Copy link
Contributor

@palmer-dabbelt can you please review this?

Palmer doesn't work at SiFive anymore (😢) so you'd be hard pressed to get his review on this. (Palmer, if you do see the notification, hello! Hope you're well!) Bunnaroath and I are the maintainers of Freedom E SDK.

@kenzhang82
Copy link
Author

Hi @nategraff-sifive, thanks for letting me know that Palmer doesn't work at SiFive anymore.

Hi @bsousi5, thanks for the review and feedback, I wonder how we should go handle the case of RTL simulation where the FPGA bitstream and bootROM doesn't really matter. Maybe add a simulation mode option to the script?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants