Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fetch svg from asset path #56

Merged
merged 29 commits into from
May 21, 2024
Merged

Conversation

danielleroux
Copy link
Collaborator

🆕 What is the new behavior?

Activate v3 preview feature with a meta header tag

<meta name="ix-icons:v3-preview" content="svg-path-loading;" />

Define a custom svg fetching path via

<meta name="ix-icons:path" content="/my/path/to/asset/folder/with/the/svgs" />

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Apr 22, 2024

🦋 Changeset detected

Latest commit: 1e271a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@siemens/ix-icons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

README.md Outdated Show resolved Hide resolved
src/components/icon/meta-tag.ts Outdated Show resolved Hide resolved
src/components/icon/resolveIcon.ts Outdated Show resolved Hide resolved
@danielleroux danielleroux merged commit 858426a into main May 21, 2024
2 checks passed
@danielleroux danielleroux deleted the feat/fetch-svg-from-path branch May 21, 2024 06:00
@github-actions github-actions bot mentioned this pull request May 21, 2024
a-wissing added a commit to Backdate/ix-icons that referenced this pull request May 28, 2024
feat: fetch svg from asset path (siemens#56)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants