Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename --stash to --autostash? #9

Closed
sharkdp opened this issue Nov 24, 2021 · 2 comments
Closed

Rename --stash to --autostash? #9

sharkdp opened this issue Nov 24, 2021 · 2 comments

Comments

@sharkdp
Copy link

sharkdp commented Nov 24, 2021

The --stash functionality of git-quickfix is similar to gits own --autostash option for a few commands. It doesn't simply stash (push) the local changes, it also stash pops afterwards.

From man git-rebase:

       --autostash, --no-autostash
           Automatically create a temporary stash entry before the
           operation begins, and apply it after the operation ends. This
           means that you can run rebase on a dirty worktree. However, use
           with care: the final stash application after a successful
           rebase might result in non-trivial conflicts.

So you could consider renaming --stash to --autostash. Or maybe rename and provide --stash as an alias (to avoid breaking changes).

@betwo
Copy link
Collaborator

betwo commented Nov 24, 2021

Originally the option was called --autostash (when introduced here: #2), but sadly I have forgotten why this was renamed to --stash on the PR.
Do you remember, @siedentop?

@siedentop
Copy link
Owner

siedentop commented Nov 28, 2021

Sorry for the late response. Thanks for raising the issue, @sharkdp. Thanks for your comment, @betwo. I don't think the option was ever --autostash in the original PR.

Let's rename the option to --autostash.

siedentop added a commit that referenced this issue Nov 28, 2021
siedentop added a commit that referenced this issue Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants