Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure as isn't always matched, but only when it's a full word #7

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

favna
Copy link
Contributor

@favna favna commented Jan 12, 2022

Noticed this when trying to transform isTextBasedChannel which includes as and gave this as result:

image

Copy link
Owner

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @favna! I was thinking of archiving this project, but apparently people do use it.

@sidvishnoi sidvishnoi merged commit 91cbf3d into sidvishnoi:master Jan 13, 2022
@favna
Copy link
Contributor Author

favna commented Jan 13, 2022

Thanks @favna! I was thinking of archiving this project, but apparently, people do use it.

Yeah at Sapphire we use it in this package: https://github.com/sapphiredev/documentation-plugins/tree/main/packages/ts2esm2cjs which powers the language tabs on our guide, seen here: https://www.sapphirejs.dev/docs/Guide/getting-started/getting-started-with-sapphire#creating-an-indexjs-file

This particular issue was on this page in fact: https://www.sapphirejs.dev/docs/Guide/arguments/creating-your-own-arguments. I wasn't sure if this package was still being actively maintained so I had temporarily copied the code with license but now I can switch back to the published package :)

@favna favna deleted the fix/as-matching branch January 13, 2022 18:46
@sidvishnoi
Copy link
Owner

Oh, that's a brilliant use case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants