Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return VECTOR values as array of numbers instead of raw Buffer #2894

Merged
merged 5 commits into from
Jul 27, 2024

Conversation

sidorares
Copy link
Owner

this is a continuation of work started in #2866

with this change VECTOR values are returned as array of JS numbers

Copy link

codecov bot commented Jul 27, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 88.13%. Comparing base (3659488) to head (3dbb79d).

Files Patch % Lines
lib/packets/packet.js 20.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2894      +/-   ##
==========================================
- Coverage   88.18%   88.13%   -0.05%     
==========================================
  Files          71       71              
  Lines       12875    12889      +14     
  Branches     1350     1353       +3     
==========================================
+ Hits        11354    11360       +6     
- Misses       1521     1529       +8     
Flag Coverage Δ
compression-0 88.13% <42.85%> (-0.05%) ⬇️
compression-1 88.13% <42.85%> (-0.05%) ⬇️
tls-0 87.55% <42.85%> (-0.05%) ⬇️
tls-1 87.89% <42.85%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wellwelwel
Copy link
Collaborator

Just a note

@sidorares, for some reason the (non-related) test/esm/regressions/2052.test.mjs is failing on Windows.

@sidorares
Copy link
Owner Author

Just a note

@sidorares, for some reason the (non-related) test/esm/regressions/2052.test.mjs is failing on Windows.

It was failing on a mac as well, I believe hasIncorrectPrepareParameter was calculated incorrectly for 8.0.39

@sidorares sidorares merged commit 9576742 into master Jul 27, 2024
68 checks passed
@sidorares sidorares mentioned this pull request Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants