Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stream): reads should emit the dataset number for each dataset #2628

Merged
merged 12 commits into from
May 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/commands/query.js
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ class Query extends Command {
if (this.onResult) {
this._rows[this._resultIndex].push(row);
} else {
this.emit('result', row);
this.emit('result', row, this._resultIndex);
}
return Query.prototype.row;
}
Expand All @@ -268,11 +268,11 @@ class Query extends Command {
stream._read = () => {
this._connection && this._connection.resume();
};
this.on('result', row => {
this.on('result', (row, resultSetIndex) => {
if (!stream.push(row)) {
this._connection.pause();
}
stream.emit('result', row); // replicate old emitter
stream.emit('result', row, resultSetIndex); // replicate old emitter
});
this.on('error', err => {
stream.emit('error', err); // Pass on any errors
Expand Down
55 changes: 55 additions & 0 deletions test/integration/test-multi-result-streaming.test.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
'use strict';

const { assert } = require('poku');
const { createConnection } = require('../common.test.cjs');

(async () => {
const conn = createConnection({ multipleStatements: true });
const captured1 = [];
const captured2 = [];
const sql1 =
'select * from information_schema.columns order by table_schema, table_name, column_name limit 1;';
const sql2 =
'select * from information_schema.columns order by table_schema, table_name, ordinal_position limit 1;';

await conn.promise().query('set global max_allowed_packet=524288000');

const compare1 = await conn.promise().query(sql1);
const compare2 = await conn.promise().query(sql2);

if (!compare1 || compare1.length < 1) {
assert.fail('no results for comparison 1');
}
if (!compare2 || compare2.length < 1) {
assert.fail('no results for comparison 2');
}

const stream = conn.query(`${sql1}\n${sql2}`).stream();
stream.on('result', (row, datasetIndex) => {
if (datasetIndex === 0) {
captured1.push(row);
} else {
captured2.push(row);
}
});
// note: this is very important:
// after each result set is complete,
// the stream will emit "readable" and if we don't
// read then 'end' won't be emitted and the
// test will hang.
stream.on('readable', () => {
stream.read();
});

await new Promise((resolve, reject) => {
stream.on('error', (e) => reject(e));
stream.on('end', () => resolve());
});

assert.equal(captured1.length, 1);
assert.equal(captured2.length, 1);
assert.deepEqual(captured1[0], compare1[0][0]);
assert.deepEqual(captured2[0], compare2[0][0]);

conn.end();
})();
Loading