fix: resolve LRU conflicts, cache loss and premature engine breaking …

…change (#2988) * fix: resolve LRU conflicts and unintentional engine breaking change * chore: update lru.min * chore: update lru.min * chore: update lru.min * chore: update lru.min
sidorares · Sep 11, 2024 · 2c3c858 · 2c3c858
1 parent 0b01333
commit 2c3c858
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 20 deletions.
diff --git a/lib/connection.js b/lib/connection.js
@@ -22,7 +22,7 @@ const EventEmitter = require('events').EventEmitter;
 const Readable = require('stream').Readable;
 const Queue = require('denque');
 const SqlString = require('sqlstring');
-const LRU = require('lru-cache').default;
+const { createLRU } = require('lru.min');
 
 const PacketParser = require('./packet_parser.js');
 const Packets = require('./packets/index.js');
@@ -75,9 +75,9 @@ class Connection extends EventEmitter {
     this._command = null;
     this._paused = false;
     this._paused_packets = new Queue();
-    this._statements = new LRU({
+    this._statements = createLRU({
       max: this.config.maxPreparedStatements,
-      dispose: function(statement) {
+      onEviction: function(_, statement) {
         statement.close();
       }
     });
@@ -411,7 +411,7 @@ class Connection extends EventEmitter {
     err.code = code || 'PROTOCOL_ERROR';
     this.emit('error', err);
   }
-  
+
   get fatalError() {
     return this._fatalError;
   }

diff --git a/lib/parsers/parser_cache.js b/lib/parsers/parser_cache.js
@@ -1,8 +1,8 @@
 'use strict';
 
-const LRU = require('lru-cache').default;
+const { createLRU } = require('lru.min');
 
-let parserCache = new LRU({
+const parserCache = createLRU({
   max: 15000,
 });
 
@@ -51,7 +51,7 @@ function getParser(type, fields, options, config, compiler) {
 }
 
 function setMaxCache(max) {
-  parserCache = new LRU({ max });
+  parserCache.resize(max);
 }
 
 function clearCache() {

diff --git a/lib/parsers/string.js b/lib/parsers/string.js
@@ -1,9 +1,9 @@
 'use strict';
 
 const Iconv = require('iconv-lite');
-const LRU = require('lru-cache').default;
+const { createLRU } = require('lru.min');
 
-const decoderCache = new LRU({
+const decoderCache = createLRU({
   max: 500,
 });
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -63,7 +63,7 @@
     "generate-function": "^2.3.1",
     "iconv-lite": "^0.6.3",
     "long": "^5.2.1",
-    "lru-cache": "^8.0.0",
+    "lru.min": "^1.0.0",
     "named-placeholders": "^1.1.3",
     "seq-queue": "^0.0.5",
     "sqlstring": "^2.3.2"