chore: enable TPM2 by default in CI #9783
Open
+18
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With some tests requiring TPM and others benefitting from it (SELinux label test) it's better to always enable it as our CI has swtpm installed. Do not automatically enable TPM2 in talosctl as it might be a breaking change to users who do not have swtpm available. Partially reverts: a13f82c regarding tests Signed-off-by: Dmitry Sharshakov <[email protected]>
smira
reviewed
Nov 25, 2024
| @@ -24,7 +24,7 @@ case "${FACTORY_BOOT_METHOD:-iso}" in | |||
| QEMU_FLAGS+=("--ipxe-boot-script=${FACTORY_SCHEME}://${PXE_FACTORY_HOSTNAME}/pxe/${FACTORY_SCHEMATIC}/${FACTORY_VERSION}/metal-amd64") | |||
| ;; | |||
| secureboot-iso) | |||
| QEMU_FLAGS+=("--iso-path=${FACTORY_SCHEME}://${FACTORY_HOSTNAME}/image/${FACTORY_SCHEMATIC}/${FACTORY_VERSION}/metal-amd64-secureboot.iso" "--with-tpm2" "--encrypt-ephemeral" "--encrypt-state" "--disk-encryption-key-types=tpm") | |||
There was a problem hiding this comment.
I'm not sure why it got removed here
There was a problem hiding this comment.
If we run all tests with TPM2 we don't need it here. However we shouldn't do it for all
There was a problem hiding this comment.
we have at least in the misc section the test with UEFI disabled (BIOS mode), this could be a good place with disabled tpm2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some tests requiring TPM and others benefitting from it (SELinux label test) it's better to always enable it as our CI has swtpm installed.
Do not automatically enable TPM2 in talosctl as it might be a breaking change to users who do not have swtpm available.
Partially reverts: a13f82c regarding tests
Signed-off-by: Dmitry Sharshakov [email protected]