Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support lvm auto activation #9333

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

frezbo
Copy link
Member

@frezbo frezbo commented Sep 18, 2024

Support lvm auto-activation as per
https://man7.org/linux/man-pages/man7/lvmautoactivation.7.html.

This changes from how Talos previously used to unconditionally tried to activate all volume groups to based on udev events.

Fixes: #9300

Copy link
Member

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks 🆒

internal/app/machined/pkg/controllers/block/lvm.go Outdated Show resolved Hide resolved
internal/app/machined/pkg/controllers/block/lvm.go Outdated Show resolved Hide resolved
internal/app/machined/pkg/controllers/block/lvm.go Outdated Show resolved Hide resolved
internal/app/machined/pkg/controllers/block/lvm.go Outdated Show resolved Hide resolved
@frezbo frezbo force-pushed the feat/lvm-auto-activation branch 5 times, most recently from 110a372 to 61c34df Compare September 20, 2024 01:08
Support lvm auto-activation as per
https://man7.org/linux/man-pages/man7/lvmautoactivation.7.html.

This changes from how Talos previously used to unconditionally tried to
activate all volume groups to based on udev events.

Fixes: siderolabs#9300

Signed-off-by: Noel Georgi <[email protected]>
@frezbo
Copy link
Member Author

frezbo commented Sep 20, 2024

/m

@talos-bot talos-bot merged commit d8ab498 into siderolabs:main Sep 20, 2024
50 checks passed
@frezbo frezbo deleted the feat/lvm-auto-activation branch September 20, 2024 10:22
@smira smira mentioned this pull request Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backported
Development

Successfully merging this pull request may close these issues.

Boot failed on hosts with LVM thin/raid logical volumes
3 participants