Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidero should support hostname as Wireguard endpoint #896

Closed
smira opened this issue Jul 7, 2022 · 0 comments · Fixed by #898
Closed

Sidero should support hostname as Wireguard endpoint #896

smira opened this issue Jul 7, 2022 · 0 comments · Fixed by #898
Assignees
@utkuozdemir

Comments

@smira
Copy link
Member

smira commented Jul 7, 2022

SIDERO_CONTROLLER_MANAGER_SIDEROLINK_ENDPOINT should support hostnames which are resolved to IP on startup:

invalid Wireguard endpoint: ParseIP("sidero.dev.net"): unexpected character
@utkuozdemir utkuozdemir self-assigned this Jul 15, 2022
utkuozdemir added a commit to utkuozdemir/sidero that referenced this issue Jul 15, 2022
@utkuozdemir
fix: resolve wireguard endpoint to IP
a01d26c 
If wireguard endpoint is set to be a hostname and not an IP, attempt to resolve it to an IP instead of failing immediately.

Closes siderolabs#896.

Signed-off-by: Utku Ozdemir <[email protected]>
@utkuozdemir utkuozdemir mentioned this issue Jul 15, 2022
Merged
utkuozdemir added a commit to utkuozdemir/sidero that referenced this issue Jul 15, 2022
@utkuozdemir
fix: resolve wireguard endpoint to IP
1bf4178 
If wireguard endpoint is set to be a hostname and not an IP, attempt to resolve it to an IP instead of failing immediately.

Closes siderolabs#896.

Signed-off-by: Utku Ozdemir <[email protected]>
(cherry picked from commit 4e714a1)
utkuozdemir added a commit to utkuozdemir/sidero that referenced this issue Jul 15, 2022
@utkuozdemir
fix: resolve wireguard endpoint to IP
acba599 
If wireguard endpoint is set to be a hostname and not an IP, attempt to resolve it to an IP instead of failing immediately.

Closes siderolabs#896.

Signed-off-by: Utku Ozdemir <[email protected]>
(cherry picked from commit 4e714a1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@utkuozdemir utkuozdemir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: resolve wireguard endpoint to IP utkuozdemir/sidero
2 participants
@smira @utkuozdemir